[BUGFIX] Batch Expectations correctly handle date min and max values
#10613
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #10613 +/- ##
===========================================
- Coverage 80.31% 80.31% -0.01%
===========================================
Files 463 463
Lines 40077 40087 +10
===========================================
+ Hits 32189 32195 +6
- Misses 7888 7892 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| import pandas as pd | ||
| import sqlalchemy.dialects.postgresql as POSTGRESQL_TYPES |
There was a problem hiding this comment.
we shouldn't import directly from sqlalchemy
There was a problem hiding this comment.
Note to non-Josh folks: the postgresql types were just imported from the sqla types, so they are equivalent. Which explains mypy being fine with this change.
| import pandas as pd | ||
| import sqlalchemy.dialects.postgresql as POSTGRESQL_TYPES |
There was a problem hiding this comment.
Note to non-Josh folks: the postgresql types were just imported from the sqla types, so they are equivalent. Which explains mypy being fine with this change.
|
Why'd this break now (or I'm assuming as of v1?) |
|
it seems like this broke because V1 now deserializes the |
invoke lint(usesruff format+ruff check)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!