[MAINTENANCE] Sqlite integration testing #10657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10657 +/- ##
===========================================
+ Coverage 80.37% 80.45% +0.07%
===========================================
Files 463 462 -1
Lines 40113 40098 -15
===========================================
+ Hits 32240 32259 +19
+ Misses 7873 7839 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
billdirks
approved these changes
Nov 12, 2024
| data: pd.DataFrame, | ||
| extra_data: Mapping[str, pd.DataFrame], | ||
| ) -> BatchTestSetup: | ||
| tmp_path = request.getfixturevalue("tmp_path") |
There was a problem hiding this comment.
I didn't know we could run fixtures this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: sqlite won't let us prefix table names with
sqlite(we previously prefixed table names with the config's label, i.e. the datasource type). The datasource type didn't seem add any extra data (like if I'm looking at a table in snowflake, I probably know it's a snowflake table), so I just removed that from the table name.invoke lint(usesruff format+ruff check)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!