Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Reduce test duration of flakey test #10663

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

tyler-hoffman
Copy link
Contributor

@tyler-hoffman tyler-hoffman commented Nov 13, 2024

This test fails with some regularity in CI, but not in the way the test expects. See this example. It fails with Failed: Timeout >2.0s because we currently invoke pytest with --timeout=2, so we would would never fail the assertion as written.

We could also throw a mark.pytest.slow on this instead of cutting the time in half, but I'm not sure if that matters.

The fix here:

  • Reduce the expected time and large_number by half so we can see the expected error if appropriate. I'm assuming complexity is O(n) with large_number.
  • Then reduce large_number by another 25% to avoid the flakiness.
  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@tyler-hoffman tyler-hoffman requested review from dctalbot and a team November 13, 2024 20:11
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit bb7cb65
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/673508dacf07fe00089962d8

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.45%. Comparing base (a3058e5) to head (bb7cb65).
Report is 4 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10663      +/-   ##
===========================================
- Coverage    80.45%   80.45%   -0.01%     
===========================================
  Files          462      462              
  Lines        40102    40102              
===========================================
- Hits         32264    32263       -1     
- Misses        7838     7839       +1     
Flag Coverage Δ
3.10 68.15% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.10 trino ?
3.11 68.13% <ø> (-0.02%) ⬇️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark ?
3.11 spark_connect ?
3.11 trino ?
3.12 68.15% <ø> (-0.01%) ⬇️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.49% <ø> (ø)
3.12 aws_deps 46.14% <ø> (ø)
3.12 big 54.74% <ø> (ø)
3.12 databricks 47.88% <ø> (ø)
3.12 filesystem 61.71% <ø> (ø)
3.12 mssql 51.49% <ø> (ø)
3.12 mysql 51.56% <ø> (ø)
3.12 postgresql 54.64% <ø> (ø)
3.12 snowflake 48.85% <ø> (ø)
3.12 spark 58.06% <ø> (ø)
3.12 spark_connect 46.44% <ø> (ø)
3.12 trino 52.68% <ø> (ø)
3.9 68.18% <ø> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.49% <ø> (ø)
3.9 aws_deps 46.16% <ø> (ø)
3.9 big 54.76% <ø> (ø)
3.9 clickhouse 43.03% <ø> (ø)
3.9 databricks 47.89% <ø> (ø)
3.9 filesystem 61.73% <ø> (ø)
3.9 mssql 51.47% <ø> (ø)
3.9 mysql 51.54% <ø> (ø)
3.9 postgresql 54.62% <ø> (ø)
3.9 snowflake 48.87% <ø> (ø)
3.9 spark 58.02% <ø> (ø)
3.9 spark_connect 46.45% <ø> (ø)
3.9 trino 52.66% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 53.35% <ø> (ø)
docs-creds-needed 52.92% <ø> (ø)
docs-spark 52.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this test continues to be a problem, we can just remove it. It's shoehorning a benchmark into a test, and really we could use a more holistic performance assessment setup in CI.

@tyler-hoffman tyler-hoffman added this pull request to the merge queue Nov 14, 2024
Merged via the queue into develop with commit 73c5334 Nov 14, 2024
70 checks passed
@tyler-hoffman tyler-hoffman deleted the m/_/reduce-test-time-limit branch November 14, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants