Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit f0f0952

Browse files
committedJun 27, 2024
add clarifications to the comment above the lint rule
1 parent 7f744cd commit f0f0952

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed
 

‎scripts/vet.sh

+3
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@ not git grep "\(import \|^\s*\)\"google.golang.org/grpc/interop/grpc_testing" --
7070
git grep '"github.com/envoyproxy/go-control-plane/envoy' -- '*.go' ':(exclude)*.pb.go' | not grep -v 'pb "\|grpc "'
7171

7272
# - Ensure all context usages are done with timeout.
73+
# Context tests under benchmark are excluded as they are testing the performance of context.Background() and context.TODO().
74+
# TODO: Remove the exclusions once the tests are updated to use context.WithTimeout().
75+
# See https://github.com/grpc/grpc-go/issues/7304
7376
git grep -e 'context.Background()' --or -e 'context.TODO()' -- "*_test.go" | grep -v "benchmark/primitives/context_test.go" | grep -v "credential
7477
s/google" | grep -v "internal/transport/" | grep -v "xds/internal/" | grep -v "security/advancedtls" | grep -v 'context.WithTimeout(' | not grep -v 'context.WithCancel('
7578

0 commit comments

Comments
 (0)
Please sign in to comment.