Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: rename fields for clarity #8043

Merged
merged 1 commit into from
Jan 28, 2025
Merged

cleanup: rename fields for clarity #8043

merged 1 commit into from
Jan 28, 2025

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jan 28, 2025

Mostly around the "stream" types. Also some cryptically named fields in ClientConn/etc and local variables.

RELEASE NOTES: none

@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Jan 28, 2025
@dfawley dfawley added this to the 1.71 Release milestone Jan 28, 2025
@dfawley dfawley requested a review from easwars January 28, 2025 00:14
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 84.37500% with 20 lines in your changes missing coverage. Please review.

Project coverage is 82.34%. Comparing base (9d4fa67) to head (ceaf641).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
stream.go 82.14% 12 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8043      +/-   ##
==========================================
- Coverage   82.35%   82.34%   -0.01%     
==========================================
  Files         383      383              
  Lines       38776    38776              
==========================================
- Hits        31933    31932       -1     
+ Misses       5532     5531       -1     
- Partials     1311     1313       +2     
Files with missing lines Coverage Δ
clientconn.go 92.45% <100.00%> (-0.27%) ⬇️
dialoptions.go 90.80% <100.00%> (ø)
rpc_util.go 80.67% <100.00%> (ø)
server.go 82.62% <100.00%> (+0.62%) ⬆️
stream.go 81.69% <82.14%> (ø)

... and 18 files with indirect coverage changes

@easwars easwars assigned dfawley and unassigned easwars Jan 28, 2025
@dfawley dfawley merged commit 3409a56 into grpc:master Jan 28, 2025
15 checks passed
@dfawley dfawley deleted the names branch January 28, 2025 15:55
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Jan 30, 2025
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 13, 2025
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 13, 2025
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants