-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpcsync : Remove OnceFunc #8049
Merged
ashishksrivastava
merged 1 commit into
grpc:master
from
ashishksrivastava:aks-remove-grpcsync-oncefunc
Jan 30, 2025
Merged
grpcsync : Remove OnceFunc #8049
ashishksrivastava
merged 1 commit into
grpc:master
from
ashishksrivastava:aks-remove-grpcsync-oncefunc
Jan 30, 2025
+15
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…rting go1.22
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8049 +/- ##
==========================================
+ Coverage 82.13% 82.24% +0.11%
==========================================
Files 384 383 -1
Lines 38927 38922 -5
==========================================
+ Hits 31971 32013 +42
+ Misses 5618 5583 -35
+ Partials 1338 1326 -12
|
arjan-bal
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, adding a second reviewer.
easwars
approved these changes
Jan 29, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove grpcsync.OnceFunc as OnceFunc is part of standard sync lib starting go1.21
Fixes: #8016
RELEASE NOTES: N/A