resolver/manual: allow calling UpdateState with an un-Built resolver #8150
+59
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unexport mutex-protected CC field
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8150 +/- ##
==========================================
+ Coverage 82.30% 82.42% +0.12%
==========================================
Files 392 392
Lines 39140 39140
==========================================
+ Hits 32213 32262 +49
+ Misses 5605 5573 -32
+ Partials 1322 1305 -17
🚀 New features to boost your workflow:
|
arjan-bal
approved these changes
Mar 6, 2025
Comment on lines
-112
to
-114
| if r.CC == nil { | ||
| panic("cannot update state as channel has not exited IDLE state") | ||
| } |
There was a problem hiding this comment.
That's clever, even if we call UpdateState before creating the resolver, it saves the state for later and returns. The saved state gets used when the resolver is built.
Does this make InitialState redundant? IIUC every caller of InitialState should now be able to call UpdateState.
There was a problem hiding this comment.
Yes, that's true, we probably don't need InitialState anymore. Maybe let's do a mini-migration after all these Dial->NewClient changes are done?
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, unexport mutex-protected CC field, since it's impossible to safely access. And delete ReportError since it's just passed through to CC.
RELEASE NOTES: none