Add .tool-versions To Version Control For Java
#26903
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to specify the Java version for this project, for tools that recognise this file such as `asdf`.
mxdvl
approved these changes
Feb 13, 2024
DanielCliftonGuardian
approved these changes
Feb 14, 2024
|
Seen on ADMIN-PROD (merged by @JamieB-gu 11 minutes and 11 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @JamieB-gu 13 minutes and 21 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to specify the Java version for this project, for tools that recognise this file such as
asdf. MAPI has already been doing this for a while: https://github.com/guardian/mobile-apps-api/pull/2316We also already do something similar for Node in
frontend:frontend/.nvmrc
Line 1 in eb7fdfa
We could also consider moving the Node version into
.tool-versionsat some point in the future, so one tool can manage both.If anyone reading this PR thinks this may cause a problem for their workflow please comment! I've tagged several people who've committed to frontend over the last couple of weeks for this reason.