fixed possible replace-bug, formatting, PSv2 compat #12
+38
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed changes: - Replaced backtick line continuations with the pipe which naturally supports multi-line (https://get-powershellblog.blogspot.com/2017/07/bye-bye-backtick-natural-line.html#pipelineop) - Replaced aliases with Full cmdlet names - Replaced the `Where-Object` comparison statement with a scriptblock as comparison statements are new in PowerShell v3 and thus will not work on Windwos 7/Server 2008 out of the box (https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/where-object?view=powershell-6) - Added "OneDrive" to the excluded folders list - Removed `Foreach-Object` (`%`) loop as `Copy-Item` natively accepts a collection of files as pipeline input - Switched `.Replace($item.BaseName,"")` which was dangerous because if the basename occurs multiple times in a path such as `"C:\Users\Henry\Pictures\Henry.jpg"` all occurrences would have been removed with safer `$item.Parent.FullName` - Introduced constant array for holding folder names to be excluded
guitarrapc
requested changes
Oct 25, 2018
|
Thank you for the PR. I appreciate a lot about considering much nice way:) |
Co-Authored-By: jantari <jantari@live.com>
Co-Authored-By: jantari <jantari@live.com>
|
thank you for your check. Merge it:) |
|
Thanks for the quick responses and merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Where-Objectcomparison statement with a scriptblock as comparison statements are new in PowerShell v3 and thus will not work on Windwos 7/Server 2008 out of the box (https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/where-object?view=powershell-6)Foreach-Object(%) loop asCopy-Itemnatively accepts a collection of files as pipeline input.Replace($item.BaseName,"")which was dangerous because if the basename occurs multiple times in a path such as"C:\Users\Henry\Pictures\Henry.jpg"all occurrences would have been removed with safer$item.Parent.FullName