Convert stmt_html output to use stmt_viz output #7516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR: if we request `stmt_viz` without `assembly`, just generate the latter to a temp file that we dispose of later; this wasn't feasible before since we were previously requiring the assembly output to be generated with the same directory and basename as stmt_viz, but that was fixed.
Per discussion on #7507, this entirely removes the "classic" stmt_html output and replaces it with the "new" StmtToViz output. Using `compile_to_lowered_stmt` or requesting `stmt_html` will now always output the new output, and requesting `stmt_viz` output is no longer legal. (Note that this builds on top of #7515, which must be submitted first.) It's not clear to me whether #7507 (comment) is a blocker for this change, or a request to add back already-lost functionality.
This was referenced Apr 17, 2023
|
It's a request to add back lost functionality. Things that used to be in codegen have crept into lowering (e.g. compiling shaders), making the .stmt output lower and lower level over time. We should roll it back a little to before those passes. |
OK, in that case we should probably be good to go in landing this. |
maaz139
reviewed
Apr 17, 2023
maaz139
approved these changes
Apr 17, 2023
maaz139
reviewed
Apr 17, 2023
src/Generator.cpp
Outdated
| bool has_assembly = std::find(emit_flags.begin(), emit_flags.end(), "assembly") != emit_flags.end(); | ||
|
|
||
| user_assert(!has_stmt_viz || has_assembly) | ||
| << "Output flag `stmt_viz` requires the `assembly` flag to also be set."; | ||
| user_assert(!has_stmt_html || has_assembly) |
There was a problem hiding this comment.
Is this still needed considering #7515 has landed?
There was a problem hiding this comment.
Oh, good catch! Removed.
steven-johnson
added a commit
that referenced
this pull request
Apr 18, 2023
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Allow emitting `stmt_viz` without specifying `assembly` TL;DR: if we request `stmt_viz` without `assembly`, just generate the latter to a temp file that we dispose of later; this wasn't feasible before since we were previously requiring the assembly output to be generated with the same directory and basename as stmt_viz, but that was fixed. * Convert stmt_html output to use stmt_viz output Per discussion on halide#7507, this entirely removes the "classic" stmt_html output and replaces it with the "new" StmtToViz output. Using `compile_to_lowered_stmt` or requesting `stmt_html` will now always output the new output, and requesting `stmt_viz` output is no longer legal. (Note that this builds on top of halide#7515, which must be submitted first.) It's not clear to me whether halide#7507 (comment) is a blocker for this change, or a request to add back already-lost functionality. * Update Makefile * Update Generator.cpp
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
…halide#7520) * Don't accidentally embed .s files in .a files when emitting stmt_html Followup fix for halide#7516 * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #7507, this entirely removes the "classic" stmt_html output and replaces it with the "new" StmtToViz output. Using
compile_to_lowered_stmtor requestingstmt_htmlwill now always output the new output, and requestingstmt_vizoutput is no longer legal.(Note that this builds on top of #7515, which must be submitted first.)
It's not clear to me whether #7507 (comment) is a blocker for this change, or a request to add back already-lost functionality.