F bsd mlock #1297
Merged
F bsd mlock #1297
+50
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `syscall` package has been frozen in favor of `x/sys`. As a result, all of the BSDs are supported and do have `mlockall(2)` support in current versions of Go.
Same syscall interface, but the `x/sys/unix` package is not frozen. No functional change from this commit.
If someone begins using Vault on Windows in dev mode, always hint so that this isn't a surprise when they get to production.
In theory Android and NaCL could build Vault now, too. List of targets derived from: `go tool dist list`
Requested by: jefferai
Word smith a tad.
I'm not entirely sure why this didn't work, but explicitly list the unsupported platforms as identified by `go tool dist list`
|
Neat! LGTM. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
mlockall(2)on FreeBSD, NetBSD, OpenBSD, and Darwin.