Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null token type bug #13236

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Conversation

ryowright
Copy link
Contributor

Similar fix to Issue #13225. Fixes panic resulting from token_type field being set to null in a request body to /v1/auth/token/roles/{role_name} to return a proper error response instead. This a fix for Issue #13232 .

@vercel vercel bot temporarily deployed to Preview – vault November 22, 2021 13:47 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 22, 2021 13:47 Inactive
@heatherezell
Copy link
Contributor

Thanks for this submission! I'll get a review going as soon as I can. :)

@heatherezell
Copy link
Contributor

Hi @ryowright - can you add a changelog entry please? Thanks! :)

@vercel vercel bot temporarily deployed to Preview – vault December 4, 2021 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook December 4, 2021 01:09 Inactive
@ryowright
Copy link
Contributor Author

Hi @hsimon-hashicorp, just added a changelog entry.

@vercel vercel bot temporarily deployed to Preview – vault-storybook December 4, 2021 01:12 Inactive
@vercel vercel bot temporarily deployed to Preview – vault December 4, 2021 01:12 Inactive
@heatherezell heatherezell merged commit 246d717 into hashicorp:main Dec 6, 2021
heppu pushed a commit to heppu/vault that referenced this pull request Jan 13, 2022
* Fixed null token panic from 'v1/auth/token/' endpoints and returned proper error response

* Fixed panic resulting from null token_type in /auth/token/roles/{role_name} to returne proper error response

* added changelog entry for PR hashicorp#13236

* edit changelog entry for PR hashicorp#13236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when token_type is null for /auth/token/roles/{role_name}
3 participants