Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add check for renewal time before triggering renew-self #13950

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Feb 8, 2022

This PR addresses a complaint where the background token renewal within the app was silently triggering a 3rd party MFA check after a few minutes of inactivity. The behavior in the UI is updated so that the token is only renewed if 3 minutes of inactivity pass and at least half of the token's TTL is passed from authentication time.

Thank you @austingebauer for your deep contributions to this PR!

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.9.x labels Feb 8, 2022
@hashishaw hashishaw added this to the 1.10 milestone Feb 8, 2022
@vercel vercel bot temporarily deployed to Preview – vault February 8, 2022 16:01 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 8, 2022 16:09 Inactive
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on tracking down the fix.

@austingebauer
Copy link
Contributor

Thank you, @hashishaw! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants