-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Switch usage of localStorage to sessionStorage #14054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks!
Why was it implemented? It causes this bug now: #15311 |
I think this has an unintended side affect of breaking all OAuth/ Single Sign On type authentication workflows because once you close the tab you are effectively signed out. If you generate a token on sign in with a 30 day refresh for example it should stay logged in even if you close the tab or use other tabs. We have to now generate lots of extra tokens which is not how OAuth should be used. Also if you use MFA with yubikeys or something it's really frustrating to have to do that flow so many extra times. |
This reverts commit 1aa506e.
Swap out use of localStorage in favor of sessionStorage across the webapp.