Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Switch usage of localStorage to sessionStorage #14054

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

hashishaw
Copy link
Contributor

Swap out use of localStorage in favor of sessionStorage across the webapp.

@hashishaw hashishaw added the ui label Feb 14, 2022
@hashishaw hashishaw added this to the 1.10 milestone Feb 14, 2022
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 14, 2022 19:27 Inactive
@vercel vercel bot temporarily deployed to Preview – vault February 14, 2022 19:27 Inactive
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@hashishaw hashishaw merged commit 1aa506e into main Feb 17, 2022
@hashishaw hashishaw deleted the ui/local-to-session-storage branch February 17, 2022 16:04
@zerkms
Copy link
Contributor

zerkms commented May 6, 2022

Why was it implemented? It causes this bug now: #15311

@danmasta
Copy link

danmasta commented May 29, 2022

I think this has an unintended side affect of breaking all OAuth/ Single Sign On type authentication workflows because once you close the tab you are effectively signed out. If you generate a token on sign in with a 30 day refresh for example it should stay logged in even if you close the tab or use other tabs.

We have to now generate lots of extra tokens which is not how OAuth should be used. Also if you use MFA with yubikeys or something it's really frustrating to have to do that flow so many extra times.

Monkeychip added a commit that referenced this pull request Jun 28, 2022
Monkeychip added a commit that referenced this pull request Jun 28, 2022
* Revert "UI: Switch usage of localStorage to sessionStorage (#14054)"

This reverts commit 1aa506e.

* remove other sessionStorage

* changelog

* keep old changelog
peteski22 pushed a commit that referenced this pull request Aug 25, 2022
* Revert "UI: Switch usage of localStorage to sessionStorage (#14054)"

This reverts commit 1aa506e.

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants