auth/ldap: add resp warning if userfilter doesn't consider userattr #14095
+108
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a response warning to config read and write endpoints if we detect that a non-empty
userfilter
does not consideruserattr
.The default userfilter config value contains the templated
{{.UserAttr}}
value which should take care of not issuing this warning for any config updates where this is not provided explicitly.However, a config may have an empty
userfilter
if users are upgrading existing Vault installations from 1.8 to 1.9, which is whenuserfilter
was introduced. In order to avoid spamming the logs, a server-side log is only printed on config reads and writes ifuserfilter
is non-empty. Thankfully the rendered search filter will default to a filter that referencesuserattr
if the configuserfilter
is empty, which in turn handles the upgrade case gracefully.Related to #11000