fix approle login IPBelongsToCIDRBlocksSlice err handling #14107
+9
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
belongs
anderr
return values fromcidrutil.IPBelongsToCIDRBlocksSlice
. In the case thaterr
is nil, the currentfmt.Errorf
with error wrapping,%w
results in printing%!w(<nil>)
which is not ideal. The errors returned fromcidrutil.IPBelongsToCIDRBlocksSlice
actually denote invalid inputs (e.g. missing IP address, emptycidrs
). This change introduces the separation of checking both return values together. If an error occurs, aLogical.ErrorResponse
will still be returned with alogical.ErrInvalidRequest
error.Fixes #14096