-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/d3 DOM cleanup hover issue #14493
Conversation
@@ -292,7 +337,7 @@ module('Acceptance | clients history tab', function (hooks) { | |||
assert.equal(currentURL(), '/vault/clients/history', 'clients/history URL is correct'); | |||
assert | |||
.dom(SELECTORS.emptyStateTitle) | |||
.includesText('No start date found', 'Empty state shows no billing start date'); | |||
.includesText('start date found', 'Empty state shows no billing start date'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for enterprise this reads "No billing start date found" and for OSS "No start date found"
this was previously passing, but started failing for some reason? so only checking for the words shared between both versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you running Vault enterprise locally with the tests (assuming it's failing locally?). The tests run on whatever version of vault you have loaded so that could be why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I am. But I thought I had changed this from hasText
to includesText
in a previous PR so that as long as "No...start date found" was present the test would pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for finding and fixing!
// Filter by namespace | ||
|
||
// check chart displays correct elements and values | ||
for (const key in CHART_ELEMENTS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
* fix duplicate rendering of chart elements * organize SVG char elements into groups, give data-test attrs * update tests * tweak mirage * add fake client counting start date * fix test * add waitUntil * adds changelog * add second waituntil
This hover bug was happening because not all of the D3 elements were removed from the page when the chart updated
cleaned up HTML into groups with fix