Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.17.9 #15044

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

cipherboy
Copy link
Contributor

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

@cipherboy cipherboy added this to the 1.10.1 milestone Apr 14, 2022
@cipherboy cipherboy requested review from ncabatoff and a team April 14, 2022 16:56
@cipherboy cipherboy force-pushed the cipherboy-update-1.10-go1.17.9 branch from 73b0ec1 to 07ef0ea Compare April 14, 2022 16:57
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 14, 2022 16:57 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 14, 2022 16:57 Inactive
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but this looks right compared to the 1.17.7 PRs

@@ -0,0 +1,3 @@
```release-note:improvement
Copy link
Contributor

@stevendpclark stevendpclark Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing against the 1.17.7 PR @mladlow had mentioned this should be within the changes section, not improvements. Looks like the the PR kept it as improvement but the release notes for 1.10 made it within the Changes section.

https://github.com/hashicorp/vault/pull/14232/files#r817105897

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
@cipherboy cipherboy force-pushed the cipherboy-update-1.10-go1.17.9 branch from 07ef0ea to dd8e912 Compare April 14, 2022 18:17
@vercel vercel bot temporarily deployed to Preview – vault April 14, 2022 18:17 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 14, 2022 18:17 Inactive
@cipherboy cipherboy merged commit 6fc5f09 into release/1.10.x Apr 14, 2022
@cipherboy cipherboy deleted the cipherboy-update-1.10-go1.17.9 branch May 17, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants