Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate policies when creating/updating identity groups #15055

Merged
merged 3 commits into from
May 16, 2022

Conversation

chrishoffman
Copy link
Contributor

Currently when adding policies to identity groups, the list is not deduplicated resulting in multiple copies of the same policy in an identity group.

@vercel vercel bot temporarily deployed to Preview – vault-storybook April 14, 2022 22:30 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 14, 2022 22:30 Inactive
@chrishoffman chrishoffman changed the title Remove duplicate policies for identity groups Remove duplicate policies when creating/updating identity groups Apr 14, 2022
@chrishoffman chrishoffman added bug Used to indicate a potential bug core/identity backport/1.10.x labels Apr 14, 2022
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 14, 2022 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 14, 2022 22:53 Inactive
@chrishoffman chrishoffman added this to the 1.11.0-rc1 milestone Apr 14, 2022
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, looks good to me

@chrishoffman chrishoffman merged commit 302ebee into main May 16, 2022
@chrishoffman chrishoffman deleted the identity_group_duplicate_policy branch May 16, 2022 21:20
Gabrielopesantos pushed a commit to Gabrielopesantos/vault that referenced this pull request Jun 6, 2022
…hicorp#15055)

* Remove duplicate policies for identity groups

* adding changelog

* test cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug core/identity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants