Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append nil months to query get to cover all requested months (OSS) #15420

Merged
merged 4 commits into from
May 16, 2022

Conversation

HridoyRoy
Copy link
Contributor

This PR fills out nil response months in activity log query handle response based on requested month data.

Unit test is in Ent PR: https://github.com/hashicorp/vault-enterprise/pull/2817/files

@HridoyRoy HridoyRoy requested review from swayne275, pmmukh and a team May 13, 2022 17:21
Copy link
Contributor

@swayne275 swayne275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally approve, but curious about the comment i made

vault/activity_log.go Show resolved Hide resolved
@HridoyRoy HridoyRoy requested review from swayne275 and ccapurso May 16, 2022 18:13
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@swayne275 swayne275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@HridoyRoy HridoyRoy merged commit b667aac into main May 16, 2022
@HridoyRoy HridoyRoy deleted the vault-6035 branch May 16, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants