Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation note about X.509/SHA-1 #15581

Merged
merged 5 commits into from
May 25, 2022
Merged

Add deprecation note about X.509/SHA-1 #15581

merged 5 commits into from
May 25, 2022

Conversation

swenson
Copy link
Contributor

@swenson swenson commented May 24, 2022

In prepration for moving to Go 1.18 in Vault 1.12.

In prepration for moving to Go 1.18 in Vault 1.12.
@swenson swenson requested review from kalafut, cipherboy and sgmiller May 24, 2022 20:26
@swenson swenson requested a review from taoism4504 as a code owner May 24, 2022 20:26
Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions.

swenson and others added 2 commits May 24, 2022 15:20
Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
@swenson
Copy link
Contributor Author

swenson commented May 25, 2022

I think I'll try to add some more notes to the AWS Auth documentation in a separate PR.

@swenson swenson merged commit 58358a7 into main May 25, 2022
@swenson swenson deleted the docs/go-1.18-breakage branch May 25, 2022 17:11
Gabrielopesantos pushed a commit to Gabrielopesantos/vault that referenced this pull request Jun 6, 2022
Add deprecation note about X.509/SHA-1

In preparation for moving to Go 1.18 in Vault 1.12.

Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants