Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed red spellcheck underline that appears for sensitive values #15681

Merged

Conversation

linda9379
Copy link
Contributor

Removed red spellcheck underline which should not be there for sensitive and secret KV values

@linda9379 linda9379 added ui bug Used to indicate a potential bug labels May 30, 2022
Copy link
Contributor

@arnav28 arnav28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be better if we make this change in the MaskedInput component. That way all the sensitive fields will have spellcheck disabled.

…lcheck does not apply for all sensitive fields
@linda9379 linda9379 requested a review from arnav28 May 31, 2022 19:42
Copy link
Contributor

@arnav28 arnav28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👏

@linda9379 linda9379 added this to the 1.11.0-rc1 milestone May 31, 2022
@linda9379 linda9379 merged commit e10df40 into main May 31, 2022
@linda9379 linda9379 deleted the ui/VAULT-6341/red_spellcheck_appears_in_sensitive_values branch May 31, 2022 21:00
Gabrielopesantos pushed a commit to Gabrielopesantos/vault that referenced this pull request Jun 6, 2022
…ashicorp#15681)

* Removed red spellcheck underline for sensitive and secret KV values

* Added changelog file

* Moved spellcheck change into masked-input component file so that spellcheck does not apply for all sensitive fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants