Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2372
My key https://keybase.io/yblanc/pgp_keys.asc is composed of subkeys, some of them are expired.
When doing the
openpgp.Encrypt
(https://github.com/hashicorp/vault/blob/main/helper/pgpkeys/encrypt_decrypt.go#L29=), it takes the first one resulting in a message I cannot decrypt.I've also tried using the upstream
golang.org/x/crypto/openpgp
and it suffers the same issue. However ProtonMail's fork does it correctly.The problem
Using main, I cannot decrypt the new unseal key, hence verify.
Using this branch, the new unseal key can be successfully decrypted.
NB: when downloading the key from keybase using
keybase:yblanc
it seems okay. We like to bake them into the AMI we use though.