Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug found in #16486
The
retry_join
loop inJoinRaftCluster
continues to execute if a call tojoin()
returns with an error.Commit introduced a change which removes an erroneous error wrapper, but did not
handle the case where a join was in progress and err == nil. This ends the
retry_join
loop and prevents a node from waiting to join.Fix this by handling the
nil
channel response and returning anerror, allowing the
retry_join
to continue.