-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplexing opt out flag #16972
Multiplexing opt out flag #16972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Couple of comments/questions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added env var flag to allow users to opt out specific plugins from the multiplexing feature as a workaround if ever necessary. Flag is added as an "in case of emergency break glass" measure and should not be used unless a critical bug in the multiplexing feature is discovered for a given plugin.
Converted the MySQL plugin to multiplexing along the way as it was used for testing, Note that only external plugins can be multiplexed so for the time being this modification changes nothing.
Bumped plugin SDK to Go18 since Vault itself upgraded to v18 recently.
Manual tests performed: