Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation status to plugin api and cli #17077

Merged
merged 13 commits into from
Sep 9, 2022
Merged

Add deprecation status to plugin api and cli #17077

merged 13 commits into from
Sep 9, 2022

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Sep 9, 2022

This PR adds builtin Deprecation Status to plugin endpoints:

  • GET /sys/plugins/catalog/:type/:name now has a deprecation_status field for builtin plugins
  • GET /sys/plugins/catalog/ now has contains deprecation_status in the detailed list.

In the event that no Deprecation Status is reported (for non-builtin plugins), the field is omitted.

plugin list now accepts a -detailed flag, which displays Deprecation Status, as well as version info.

plugin info displays Deprecation Status for builtin plugins.

@mpalmi mpalmi requested review from ccapurso, tomhjp and a team September 9, 2022 14:28
@mpalmi mpalmi requested a review from taoism4504 as a code owner September 9, 2022 14:28
@mpalmi mpalmi requested a review from a team September 9, 2022 14:28
command/plugin_info.go Outdated Show resolved Hide resolved
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some small comments.

Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions but otherwise looks good.

api/sys_plugins.go Show resolved Hide resolved
command/plugin_list.go Show resolved Hide resolved
website/content/docs/commands/plugin/info.mdx Show resolved Hide resolved
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps worth understanding that mapstructure tag requirement a little better though.

command/plugin_list.go Outdated Show resolved Hide resolved
command/plugin_list.go Show resolved Hide resolved
api/sys_plugins.go Show resolved Hide resolved
@mpalmi mpalmi merged commit 63e6cc1 into main Sep 9, 2022
@mpalmi mpalmi deleted the plugin-info branch September 9, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants