-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation status to plugin api and cli #17077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor questions but otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, perhaps worth understanding that mapstructure
tag requirement a little better though.
This PR adds builtin Deprecation Status to plugin endpoints:
GET /sys/plugins/catalog/:type/:name
now has adeprecation_status
field for builtin pluginsGET /sys/plugins/catalog/
now has containsdeprecation_status
in thedetailed
list.In the event that no Deprecation Status is reported (for non-builtin plugins), the field is omitted.
plugin list
now accepts a-detailed
flag, which displays Deprecation Status, as well as version info.plugin info
displays Deprecation Status for builtin plugins.