-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update auth/gcp to v0.14.0 #17160
update auth/gcp to v0.14.0 #17160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wonder if there should be a changelog entry here, since it looks like some improvements went into v0.14.0? https://github.com/hashicorp/vault-plugin-auth-gcp/blob/5b946419e9777e40476ee6a76c3fd4286c303050/CHANGELOG.md#L3-L8 |
@tvoran that's a good call, also made me realize I should update the changelog for the auth/gcp plugin. Here's the PR to update the changelog after the v0.14.0 release: hashicorp/vault-plugin-auth-gcp#141 |
@@ -0,0 +1,3 @@ | |||
```release-note:improvement | |||
auth/gcp: bump github.com/hashicorp/vault-plugin-auth-gcp to v0.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen us adding changelog entries for the plugin bumps themselves. The entries have mostly been focused on the bug fixes, improvements, and features added to plugins. I'm thinking this CL entry should include an entry similar to https://github.com/hashicorp/vault/pull/17174/files#diff-7c432b8c3bb8887f5e0b389cbb81f2bdf4a6964f0a42dc395a6ed5aaf639c7fc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, I opened a PR to update the previous changelog here: #17176
Updates
vault-plugin-auth-gcp
to v0.14.0Steps: