Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when pluginCatalog.Get returns (nil,nil) during cred backend creation #17204

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

@ncabatoff ncabatoff changed the title Handle when pluginCagalog.Get returns (nil,nil) during cred backend creation Handle when pluginCatalog.Get returns (nil,nil) during cred backend creation Sep 19, 2022
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I had a quick scan and this looks like the only place we don't account for a possible nil, nil return.

@ncabatoff ncabatoff enabled auto-merge (squash) September 20, 2022 12:42
@ncabatoff ncabatoff merged commit 57ac8f3 into main Sep 20, 2022
@tomhjp tomhjp deleted the fix-panic-plugincatalog-get branch December 1, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants