Plugins: Fix file permissions check to always use the correct path #17340
+107
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was a bug where the wrong path would be checked during the mount operation because we just pulled the plugin name from the config (but not during registration, because it correctly used the
command
input at that point). The plugin name often matches the binary name, but not necessarily, and it will match the name less often once people start using versioned plugins if they want two versions of the same plugin to co-exist in the plugin directory.I've committed the test first, so hopefully that should show an error which gets fixed by the second commit once the CI finishes.