-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: Filter builtins by RunningVersion #17816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable approach, but also relatively major surgery for a minor bug. Is it definitely worth the risk of backporting it? I'm not against it, just raising the question of risk and reward.
Is there a test we could write to validate the old behaviour is fixed in a proportionate amount of effort? |
Absolutely will want to add some go tests to this. Thanks for the reminder! |
This commit adds some logic to handle the case where a mount entry has a non-builtin RunningVersion. This ensures that we only report deprecation status for builtins. This resolves VAULT-9019.
364fdb0
to
266d883
Compare
Only update the status on mount and secrets/auth enable. This should resolve VAULT-9019.