UI: Update <a> tags to LinkTo's #17866
Merged
+105
−78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<a>
tags have different behavior than<LinkTo>
within our app with regards to keeping root users logged in on page load. This change is to make sure we're using<a>
tags as minimally as possible. All the current implementations of these tags are legitimate (they correctly reload the page or link to an external site) but to consolidate their usage I created a newExternalLink
component, and glimmerizedDocLink
andLearnLink
so they can extend this new component.Something I considered that is out of scope of this ticket, is using the HDS Links instead, but I think that should be follow-on work