Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error message #17904

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Added error message #17904

merged 4 commits into from
Nov 11, 2022

Conversation

divyaac
Copy link
Contributor

@divyaac divyaac commented Nov 11, 2022

@divyaac divyaac requested review from ccapurso and removed request for ccapurso November 11, 2022 17:39
@divyaac divyaac requested a review from ccapurso November 11, 2022 17:43
@@ -0,0 +1,3 @@
```release-note:bug
credential/cert: adds error message if no tls connection is found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to callout that this is specific to AliasLookahead.

Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment regarding the changelog but looks good!

@divyaac divyaac merged commit 5e2e5f0 into main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants