Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve unrecognized parameter warnings on batch_input parameter in transit #18299

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

stevendpclark
Copy link
Contributor

@stevendpclark stevendpclark commented Dec 9, 2022

While playing around with #18243, I noticed operations that properly accepted the batch_input parameter were returning warnings about it being an unrecognized parameter. This should fix those issues across the transit APIs. Also fix a little glitch in the transit docs related to a batch_input parameter description.

❯ vault secrets enable transit
Success! Enabled the transit secrets engine at: transit/
❯ vault write transit/keys/test type=rsa-4096
Success! Data written to: transit/keys/test
❯ cat input.json | vault write -format=json transit/encrypt/test - | jq
{
  "request_id": "737ad91e-1303-2992-8fdc-d62ff8b35a1d",
  "lease_id": "",
  "lease_duration": 0,
  "renewable": false,
  "data": {
    "batch_results": [
      {
        "ciphertext": "vault:v1:KBnS9or3klQK8co1FYLSW5VrKhbYVgrN83cpY+MuvQtQpLla3rXLocgFs0ZL1XaNSE0Wz0muGRUXg4wk7uPpDS6syL1a1nBeyApo9LCcq3zvMztTN8fGxUiCvzCGRi6GonlhhQ5/d4UGyyDB3tXog84lvrLknTl2T9m6qZrbNKx+oeVA6laSIv4+sQkZORRWFGM+HhnNcWelpB8C+pAfuM/OCtVwoIUdwWWypFNIhQgYc5/Jjrbe7tBTb4GUUr9GqhF5wMiIxkR54EUKMpSTDWd+q6UwTtLnLAf++/rB+pU3cuIU+AhSZPWnhSEfJSXS1Dll7T96VluolCiTdaRZ7x00sNJaVpJ47IYnp9UhpdnIaYzltxbPDn8C+KNZiqpS6SXRODEBUjMiVndIB0vymUIb+i44R+xEA1ymsrtaTl6AJ2Sjzb6x4fta0ReNvQGtMBmRrei+pNQxhW3wOzrESLEcWAMkbjHAripSe4li4qSeWYkbJBoQ7j7LFiFEBgvP8G0VWSCZLSaQAzMHbfMvpZoHmEqsdABnuUSVAc7Z8Bv99BTMfj+86rdrhXyXZKfEq3t0MdDYaKDr0Om/hX6N0bYndimzRijegEB6k4HiN/NG6pA2mB266IkuwAVbQX5A+ADRoXdDoaFWCIP7NlaDQz516BWNi44g8dugNarrsbc=",
        "key_version": 1
      },
      {
        "ciphertext": "vault:v1:bbQrBjkOllJyuYgKb5Aa+nJStcteE3loiPWU1BfAPMk3N1NeiPOa0WCfAgGPMJ/au3x+CvJvxqv6PG3yhy8ABgAaebShAIoi6dAazwB+D3qqKfhCEvuAkSYJssaVM8EfnKY+KKlxFBbZd/3XBPP4O23qJSw+Nu1tJuEMdMRixyvkvW/Wxu3K8t7Mz77gxvY4PeJLhAGexXC2k8K/bPm4dFlI5yA4+eAr0peKqyHx/1XK1qQi7Dw7l1+IB00T3wkWXF+PxUmtn4yFsocmWqI2pPLrui/YkxdEeduzx850PIQ58xdli8zJzxsVTXPqPRD3CsTly3co43SV6crY3i9Ga9lczqt0i3wtaU3Z12Hqmgjl5+Xk/iXhl1clb78ExechnTjmrH5Yr+NCIRt5rhp6AD9HylGfbL3kjXxLjNhSQh3Y9mbFMGy15pW8JjDKPp4cTO96ZnwS5O6oi2ssIEe/Wj1/2lAJPbSMcZWbi5Ih0ne5v1q6zQFvU+cLQwjplIfG6Iz6YzXD34v1lNKwFqxBz+aRyf7HcOPYiUVjjT84F5coCC7G/AwcLMGLcxZgWZO0DUjChXEFxalqIPUjFgnKG5bay6a4EPtI4H1h1vGpDXZ2+F7ALW6+1YawDW1vAs4dSuMia4TTz6yGbt4ZgoFqF0y6qcjFN49HDZkRwbaVJuo=",
        "key_version": 1
      }
    ]
  },
  "warnings": [
    "Endpoint ignored these unrecognized parameters: [batch_input]"
  ]
}

Fixes the recently reported VAULT-12557

@stevendpclark stevendpclark requested a review from a team December 9, 2022 20:40
@stevendpclark stevendpclark changed the title Resolve unused warnings on batch_input parameter in transit Resolve unrecognized parameter warnings on batch_input parameter in transit Dec 9, 2022
@stevendpclark stevendpclark force-pushed the stevendpclark/transit-batch-input-warnings branch from bd2617d to 7537143 Compare December 13, 2022 15:30
@stevendpclark stevendpclark force-pushed the stevendpclark/transit-batch-input-warnings branch from 7537143 to 10a291c Compare January 4, 2023 13:34
@stevendpclark stevendpclark added this to the 1.13.0-rc1 milestone Jan 4, 2023
@stevendpclark stevendpclark merged commit 76741f9 into main Jan 4, 2023
@stevendpclark stevendpclark deleted the stevendpclark/transit-batch-input-warnings branch January 4, 2023 14:15
@stevendpclark stevendpclark modified the milestones: 1.13.0-rc1, 1.11.7 Jan 10, 2023
stevendpclark added a commit that referenced this pull request Jan 10, 2023
…ransit (#18299)

* Resolve unused warnings on batch_input parameter in transit

* Add cl

* Fix text in hmac batch_input parameter description
stevendpclark added a commit that referenced this pull request Jan 10, 2023
…ransit (#18299)

* Resolve unused warnings on batch_input parameter in transit

* Add cl

* Fix text in hmac batch_input parameter description
stevendpclark added a commit that referenced this pull request Jan 10, 2023
…ransit (#18299) (#18653)

* Resolve unused warnings on batch_input parameter in transit

* Add cl

* Fix text in hmac batch_input parameter description

Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
stevendpclark added a commit that referenced this pull request Jan 10, 2023
…ransit (#18299) (#18654)

* Resolve unused warnings on batch_input parameter in transit

* Add cl

* Fix text in hmac batch_input parameter description

Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
AnPucel pushed a commit that referenced this pull request Jan 14, 2023
…ransit (#18299)

* Resolve unused warnings on batch_input parameter in transit

* Add cl

* Fix text in hmac batch_input parameter description
AnPucel pushed a commit that referenced this pull request Feb 3, 2023
…ransit (#18299)

* Resolve unused warnings on batch_input parameter in transit

* Add cl

* Fix text in hmac batch_input parameter description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants