-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve unrecognized parameter warnings on batch_input parameter in transit #18299
Merged
stevendpclark
merged 3 commits into
main
from
stevendpclark/transit-batch-input-warnings
Jan 4, 2023
Merged
Resolve unrecognized parameter warnings on batch_input parameter in transit #18299
stevendpclark
merged 3 commits into
main
from
stevendpclark/transit-batch-input-warnings
Jan 4, 2023
+54
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd2617d
to
7537143
Compare
sgmiller
approved these changes
Jan 3, 2023
7537143
to
10a291c
Compare
stevendpclark
added a commit
that referenced
this pull request
Jan 10, 2023
…ransit (#18299) * Resolve unused warnings on batch_input parameter in transit * Add cl * Fix text in hmac batch_input parameter description
stevendpclark
added a commit
that referenced
this pull request
Jan 10, 2023
…ransit (#18299) * Resolve unused warnings on batch_input parameter in transit * Add cl * Fix text in hmac batch_input parameter description
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
…ransit (#18299) * Resolve unused warnings on batch_input parameter in transit * Add cl * Fix text in hmac batch_input parameter description
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
…ransit (#18299) * Resolve unused warnings on batch_input parameter in transit * Add cl * Fix text in hmac batch_input parameter description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with #18243, I noticed operations that properly accepted the
batch_input
parameter were returning warnings about it being an unrecognized parameter. This should fix those issues across the transit APIs. Also fix a little glitch in the transit docs related to a batch_input parameter description.Fixes the recently reported VAULT-12557