-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add core state lock deadlock detection config option v2 #18604
Conversation
b1d05d6
to
fc4f1c7
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -1633,6 +1635,7 @@ func NewTestCluster(t testing.T, base *CoreConfig, opts *TestClusterOptions) *Te | |||
} | |||
|
|||
if base != nil { | |||
coreConfig.DetectDeadlocks = TestDeadlockDetection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very close to what I want. The only catch is, there's no way to turn it off. Maybe that's ok though, I can't come up with a good reason why I should have to be able to, given that I can use the tag. We can always revisit this later if need be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* add core state lockd eadlock detection config option v2 * add changelog * split out NewTestCluster function to maintain build flag * replace long func with constant * remove line * rename file, and move where detect deadlock flag is set
Updated PR based on #17020