Speculative fix for a panic that might arise during raft teardown #18704
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panic we're trying to fix is here: https://app.circleci.com/pipelines/github/hashicorp/vault/4864/workflows/2ca6331a-2f99-4a50-92eb-2fa7575f8695/jobs/569495/parallel-runs/7
We think we ruled out all other explanations for that panic, landing on the theory that the ticker was still firing one last shot after a teardown, e.g. when we sealed. I don't think any of the relevant code has changed in a long time, and I haven't seen this failure before, so it's presumably a very narrow race.