Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speculative fix for a panic that might arise during raft teardown #18704

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

ncabatoff
Copy link
Collaborator

Panic we're trying to fix is here: https://app.circleci.com/pipelines/github/hashicorp/vault/4864/workflows/2ca6331a-2f99-4a50-92eb-2fa7575f8695/jobs/569495/parallel-runs/7

We think we ruled out all other explanations for that panic, landing on the theory that the ticker was still firing one last shot after a teardown, e.g. when we sealed. I don't think any of the relevant code has changed in a long time, and I haven't seen this failure before, so it's presumably a very narrow race.

@ncabatoff ncabatoff merged commit 98259ce into main Jan 16, 2023
@ncabatoff ncabatoff deleted the fix-raft-teardown-panic branch January 16, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants