Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic keys from SSH Secrets Engine #18874

Merged
merged 6 commits into from
Jan 31, 2023

Conversation

cipherboy
Copy link
Contributor

@cipherboy cipherboy commented Jan 27, 2023

This removes the functionality of Vault creating keys and adding them to the authorized keys file on hosts.

This functionality has been deprecated since Vault version 0.7.2.

The preferred alternative is to use the SSH CA method, which also allows key generation but places limits on TTL and doesn't require Vault reach out to provision each key on the specified host, making it much more secure.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>


Follow-up to the removal notice as announced during 1.12 cycle in #17362.

@cipherboy cipherboy added this to the 1.13.0-rc1 milestone Jan 27, 2023
@cipherboy cipherboy requested review from sgmiller, stevendpclark and a team January 27, 2023 15:06
@cipherboy cipherboy requested a review from yhyakuna as a code owner January 27, 2023 15:15
@cipherboy cipherboy force-pushed the cipherboy-remove-dynamic-ssh-keys branch from 3a83e91 to 3c923dc Compare January 27, 2023 16:12
This removes the functionality of Vault creating keys and adding them to
the authorized keys file on hosts.

This functionality has been deprecated since Vault version 0.7.2.

The preferred alternative is to use the SSH CA method, which also allows
key generation but places limits on TTL and doesn't require Vault reach
out to provision each key on the specified host, making it much more
secure.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
@cipherboy cipherboy force-pushed the cipherboy-remove-dynamic-ssh-keys branch from 9d738db to 9a066c7 Compare January 31, 2023 15:56
@cipherboy cipherboy enabled auto-merge (squash) January 31, 2023 16:02
@cipherboy
Copy link
Contributor Author

Thanks all!

@cipherboy cipherboy merged commit 8e7f207 into main Jan 31, 2023
@cipherboy cipherboy deleted the cipherboy-remove-dynamic-ssh-keys branch April 21, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants