Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sys/leases panic when lease_id is nil #18951

Merged
merged 2 commits into from
Feb 3, 2023
Merged

fix sys/leases panic when lease_id is nil #18951

merged 2 commits into from
Feb 3, 2023

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented Feb 1, 2023

The sys/leases/lookup, sys/leases/revoke, and sys/leases/renew endpoints currently panic when the provided lease_id is nil. This PR handles this scenario as if lease_id was not provided at all and thus returns a 403 response.

Fixes #18850

@ccapurso ccapurso modified the milestones: 1.12.3, 1.11.7, 1.10.11 Feb 1, 2023
@ccapurso ccapurso requested a review from a team February 1, 2023 22:06
Copy link
Contributor

@akshya96 akshya96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lease_id null causes connection hangups on some endpoints
2 participants