Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade vault-plugin-auth-kubernetes to v0.15.0 #19094

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

kpcraig
Copy link
Contributor

@kpcraig kpcraig commented Feb 8, 2023

This PR updates vault-plugin-auth-kubernetes to v0.15.0.

Steps:

go get github.com/hashicorp/vault-plugin-auth-kubernetes@v0.15.0
go mod tidy

@kpcraig kpcraig added this to the 1.13.0-rc1 milestone Feb 8, 2023
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a changelog and reference the unreleased changes mentioned here: https://github.com/hashicorp/vault-plugin-auth-kubernetes/blob/main/CHANGELOG.md#unreleased

then we can update the plugin's changelog "Unreleased -> v0.15.0"

@kpcraig
Copy link
Contributor Author

kpcraig commented Feb 10, 2023

I added a changelog file, athough i was unsure of what the desired format would be to roll up multiple changes in the 3-line format, so i wrote something general.

@@ -0,0 +1,3 @@
```release-note:bug
auth/kubernetes: fixes and dep updates for the auth-kubernetes plugin (see plugin changelog for details)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auth/kubernetes: fixes and dep updates for the auth-kubernetes plugin (see plugin changelog for details)
auth/kubernetes: fixes and dep updates for the auth-kubernetes plugin (see [plugin changelog](https://github.com/hashicorp/vault-plugin-auth-kubernetes/blob/main/CHANGELOG.md) for details)

@kpcraig kpcraig merged commit 154dbb8 into main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants