-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Namespace area fixes #19799
UI: Namespace area fixes #19799
Conversation
ui/app/adapters/namespace.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for turning into class based!
@@ -4,21 +4,21 @@ | |||
*/ | |||
|
|||
import Model, { attr } from '@ember-data/model'; | |||
import { computed } from '@ember/object'; | |||
import { expandAttributeMeta } from 'vault/utils/field-to-attrs'; | |||
import { withExpandedAttributes } from 'vault/decorators/model-expanded-attributes'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@@ -35,7 +35,7 @@ | |||
{{#let (concat this.currentNamespace (if this.currentNamespace "/") list.item.id) as |targetNamespace|}} | |||
{{#if (includes targetNamespace this.accessibleNamespaces)}} | |||
<li class="action"> | |||
<NamespaceLink @targetNamespace={{targetNamespace}} @class="is-block"> | |||
<NamespaceLink @targetNamespace={{targetNamespace}} @unparsed={{true}} @class="is-block"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind adding documentation to the NamespaceLink component? Add unparsed
parma, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a comment about unparsed, but there's a lot in there that I have no idea what's going on 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! One request, but non-blocking.
32212e4
to
5571517
Compare
This PR fixes a couple issues with the namespaces area of the UI:
Goes to the wrong link if namespace has dots

Shows blue info banner from unexpected param

After