-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial ACME API documentation #20752
Conversation
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
The required header `Cache-Control: no-store` is automatically set by Vault in wrapGenericHandler(...). Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
27d031d
to
21b14de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 👍 I've added a bunch of nits, nothing serious.
specified, | ||
|
||
- `new-account-required`, where new accounts are required to have EAB | ||
but existing accounts can still be used, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentence wasn't completed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, it was just a continued list. item one, / item-two, and / item-three.
:-)
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have tiny nits, this looks really great.
|
||
### List Unused ACME EAB Binding Tokens | ||
|
||
This endpoint returns a list of all unused ACME binding tokens; once used, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is authed, right? (maybe say, "this authenticated endpoint")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually only list unauthenticated endpoints; its assumed endpoints are authed by default. I've added a missing note to the Directories that it is unauthed from a Vault auth perspective though. :-) thanks!
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Thanks all! |
Adds documentation about the new ACME APIs in the PKI engine!
For ticket: VAULT-13857.