-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a parameter to allow ExtKeyUsage field usage from a role #21702
Add a parameter to allow ExtKeyUsage field usage from a role #21702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Viper61 for the submission.
Looks good to me, a test for the new behavior would be nice, but we can add that after the fact, and note to myself, docs need to be updated.
Thanks for the review. Both rewording you suggested were applied. I'm trying to write a proper test. Sadly my lack of knowledge in Golang is causing me trouble. |
Thanks for the extra work @Viper61, we can handle writing of the test if you wish, let me know either way. We will also tweak a few nits such as renaming the field to |
No problem @stevendpclark. I updated the variables accordingly :) Regarding the test, either it's always showing ok, either I'm not having it running at all. Edit : Rebased the PR on current main |
Much appreciated!
No worries, I just pushed an updated unit test and I tweaked some of the UI label text a bit in a commit pushed to your branch. |
Thanks again @Viper61 for the submission, this should make it into the next minor Vault release. |
As discussed in #21549, there is some use cases where allowing expanding ExtKeyUsage is adequate (eg containers).
This PR adds a new configuration option on ACME to allow usage of the ExtKeyUsage field defined within a role.