Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: focus navigate-input after automatic page filter #21767

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Jul 11, 2023

I will be the first to say: this solution is hacky. But the right way to do it involves a total refactor of how we do page filtering, which is not feasible to backport into a minor version. So here we are.

This PR addresses #21451 (by auto-focusing on page reload) and #21452 (by using <Input> component).

The UI will still be a little weird, but it won't completely drop your input focus after 1 character:
policy-filter

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.14.x labels Jul 11, 2023
@hashishaw hashishaw added this to the 1.14.1 milestone Jul 11, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 11, 2023
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your statements and while not ideal I think this will suffice until we can fully rework this in a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL Search results include last policy - except when I search for it Search-field losing focus with new UI
2 participants