Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid unnecessary byte/string conversion calls #21854

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

thevilledev
Copy link
Contributor

Currently the Vault codebase has mixed use of explicit byte/string conversion calls and Go stdlib functionalities such as WriteString() or NewBufferString(). This PR aligns all remaining byte/string conversions to use stdlib instead. While this could have a gain in performance, it mostly impacts test files. I consider this more of a code quality improvement.

@thevilledev thevilledev requested a review from a team July 14, 2023 12:08
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this. I'll run all the checks and hopefully merge this shortly :)

@VioletHynes VioletHynes enabled auto-merge (squash) August 8, 2023 17:42
@VioletHynes VioletHynes merged commit eefd452 into hashicorp:main Aug 8, 2023
@thevilledev thevilledev deleted the chore/avoid-conversion branch August 16, 2023 06:04
hellobontempo pushed a commit that referenced this pull request Aug 18, 2023
* chore: avoid unnecessary conversion calls

* add changelog entry

---------

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants