-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display CertificateCard instead of MaskedInput for certificates in PKI #22160
Merged
malinac02
merged 12 commits into
main
from
ui/VAULT-18490/display-CertificateCard-for-certificates-in-PKI
Aug 10, 2023
Merged
Display CertificateCard instead of MaskedInput for certificates in PKI #22160
malinac02
merged 12 commits into
main
from
ui/VAULT-18490/display-CertificateCard-for-certificates-in-PKI
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes configuration-test.js
…xpand test for pki-issuer-details-test.js to check for all issuer details
…ing) depending on the value provided. update 2 test files to account for this.
malinac02
commented
Aug 9, 2023
malinac02
commented
Aug 9, 2023
…more inclusive of different uses of CertificateCard (i.e when used for a private key, not a certificate). add description to certificate-card.js
malinac02
commented
Aug 9, 2023
…reflect the change from MaskedInput to CertificateCard
malinac02
commented
Aug 10, 2023
malinac02
commented
Aug 10, 2023
Build Results: |
CI Results: |
zofskeez
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left some comments but nothing blocking from my perspective 🎉
…onent CertificateCard. edit pki-certificate-details.hbs to get rid of extraneous code
hellobontempo
pushed a commit
that referenced
this pull request
Aug 18, 2023
#22160) * replaced each instance of MaskedInput in PKI with CertificateCard * modify tests for pki-generate-csr * add test for pki-issuer-details. modify test for pki-certificate-details * added test for pki-key-details. modified test for pki-sign-intermediate-form * update 2 test helper files and modify test for pki-issuer-rotate-root * update test for certificate-card-test.js, update test for the kubernetes configuration-test.js * modify pki-action-forms-test.js to no longer look for masked input. expand test for pki-issuer-details-test.js to check for all issuer details * change CertificateCard to show different format types (PEM, DER, nothing) depending on the value provided. update 2 test files to account for this. * change CertificateCard arg name from @certficateValue to @DaTa to be more inclusive of different uses of CertificateCard (i.e when used for a private key, not a certificate). add description to certificate-card.js * change naming for attr.options.masked to attr.options.displayCard to reflect the change from MaskedInput to CertificateCard * add changelog * change attribute to isCertificate to better fit the title of the component CertificateCard. edit pki-certificate-details.hbs to get rid of extraneous code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the PKI secrets engine, the
<MaskedInput>
component is for several attributes: Certificate, CA Chain, Issuing CA, CSR, and Private Key. This PR changes this so that now these attributes are shown using the<CertificateCard>
component instead. (For reference,<CertificateCard>
is also used in the Kubernetes secret engine, on the configuration page)Unlike with the
<MaskedInput>
, the data now shown with the<CertificateCard>
is...Reproduction steps:
The
<CertificateCard>
shows up in many places. Three examples are when you configure the PKI engine, generate a new Issuer, or view a certificate in the certificates tab.<CertificateCard>
shows up for the attributes Certificate, CA Chain, Issuing CA, CSR, and Private Key.Before:

After:

