Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update azurevaultkey wrapper dependency #22994

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

jimlambrt
Copy link
Contributor

@jimlambrt jimlambrt commented Sep 12, 2023

This update brings in PR #155 from go-kms-wrapping which adds support for azure workload identity authentication. The go-kms-wrapping PR was tested by @moduli with the help of some vault folks.

This update brings in PR #155 from go-kms-wrapping which adds support for azure
workload identity authentication
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 12, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks :)

@jimlambrt jimlambrt added this to the 1.15.0 milestone Sep 12, 2023
@VioletHynes VioletHynes merged commit 771470c into main Sep 12, 2023
@VioletHynes VioletHynes deleted the jimlambrt-azurekey-vault-dependency branch September 12, 2023 16:31
@ibauersachs
Copy link

@jimlambrt I think something went wrong with this PR? The go-kms-wrapping is still at v2.0.8, even in main as of today:

vault/go.mod

Line 95 in 511ce92

github.com/hashicorp/go-kms-wrapping/wrappers/azurekeyvault/v2 v2.0.8

The change from hashicorp/go-kms-wrapping#155 was first tagged in v2.0.9. Could you please have another look?

@theseion
Copy link

@jimlambrt bump. This PR should have changed the azurekeyvault/v2 module to v2.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants