UI: [VAULT-19982] confirm delete modal for namespaces #23066
Merged
+5
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting a height using inline styles directly in the template causes Content Security Policy errors.
Content Security Policy errors from putting inline styles:

The bug:

A few solutions to possibly prevent the Content Security Policy error:
Solution 1:
Instead of calculating the height, set a fixed
min-height
and addclass
with that min-height style. See possible solution 1 here: f5b785eSolution 2:
Add the height style directly using js instead of in our templates. I paired with Jordan a little bit on this and found that this will likely not cause Content Security Policy errors since
ember-basic-dropdown
does something similar and injects some styling and these styles are set after initial render. See possible solution 2 here: 5fa9b68