-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api/seal-status: fix deadlock when namespace is set on seal-status calls #23861
Merged
+43
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Results: |
CI Results: |
ncabatoff
approved these changes
Oct 26, 2023
raskchanky
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mpalmi
approved these changes
Oct 27, 2023
jasonodonnell
added a commit
that referenced
this pull request
Oct 27, 2023
…lls (#23861) * api/seal-status: fix deadlock when namespace is set on seal-status calls * changelog
jasonodonnell
added a commit
that referenced
this pull request
Oct 27, 2023
…lls (#23861) * api/seal-status: fix deadlock when namespace is set on seal-status calls * changelog
jasonodonnell
added a commit
that referenced
this pull request
Oct 27, 2023
…lls (#23861) * api/seal-status: fix deadlock when namespace is set on seal-status calls * changelog
jasonodonnell
added a commit
that referenced
this pull request
Oct 27, 2023
…al-status calls into release/1.13.x (#23877) * api/seal-status: fix deadlock when namespace is set on seal-status calls (#23861) * api/seal-status: fix deadlock when namespace is set on seal-status calls * changelog * oops * Fix seal type --------- Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #10725 introduced a change to support namespaces in vault status requests but introduced a deadlock on calls to
sys/seal-status
when namespaces are included.When requests have a namespace configured the handler routes the request through
switchedLockHandleRequest
and holds the read statelock for the duration of the request:vault/vault/request_handling.go
Lines 530 to 533 in 550c99a
I've added a locking arg so the caller can decide if the statelock needs to be grabbed or not.