Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only disable quotas on the primary cluster #25439

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

raskchanky
Copy link
Contributor

@raskchanky raskchanky commented Feb 15, 2024

https://hashicorp.atlassian.net/browse/VAULT-22381

tl;dr - setting up a rate limit quota inside a namespace and then deleting the namespace when perf replication is enabled causes the PR secondary to error when doing sync invalidation on the mount table and stop replication because it's trying to delete the quota from the PR secondary storage, which of course is read-only for quotas.

Making this change kept replication up and running and I verified that after the namespace was deleted on the primary, the associated rate limit was also gone from the secondary.

Although this change is to a CE file, it seems worth maybe opening this PR on ENT as well, just to let CI run?

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 15, 2024
Copy link

github-actions bot commented Feb 15, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Feb 15, 2024

Build Results:
All builds succeeded! ✅

@miagilepner
Copy link
Contributor

Although this change is to a CE file, it seems worth maybe opening this PR on ENT as well, just to let CI run?

I think that's a good idea. We could also add an ent test there for this scenario.

@raskchanky
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants