Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix aws credential generation sending ttl value when off #27366

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Jun 5, 2024

This PR fixes an issue where the AWS generate credential call's payload included TTL when the user toggles the item off in the form. This PR also fixes an issue where selecting "Session token" as the type makes the type selector disappear.

Session token selected still has type selector
image

Honestly, there was a lot of cleanup I could (and would like to) do here -- but in the interest of getting a narrowly scoped fix in before freeze, I opted to only change the things necessary and will do more cleanup afterward which will not be backported.

  • Ent tests pass
Siteproxy
@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/ent/1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Jun 5, 2024
@hashishaw hashishaw added this to the 1.15.10 milestone Jun 5, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw marked this pull request as ready for review June 5, 2024 17:57
@hashishaw hashishaw requested a review from a team as a code owner June 5, 2024 17:57
Copy link

github-actions bot commented Jun 5, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant way to fix this bug! ✨

@hashishaw hashishaw enabled auto-merge (squash) June 5, 2024 19:11
@hashishaw hashishaw enabled auto-merge (squash) June 5, 2024 19:44
@hashishaw hashishaw merged commit 67fc1fa into main Jun 5, 2024
31 checks passed
@hashishaw hashishaw deleted the ui/VAULT-26254/aws-cred-ttl-off branch June 5, 2024 19:56
@hashishaw hashishaw added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent and removed backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants