-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mixed case consul service tags on consul storage engine #6483
Conversation
Are there any backward-compat implications in here? This might be ok, since the "old" tag is still present (in addition to the new one that would no longer be dedupped), just something worth noting since it's a behavioral change. |
I don't think that's the root of the problem, I think it's that when it was coded (by a Consul/TFE dev who contributed this to us) they assumed service tags would always be lowercase. |
Is that a mis-configuration that we are incorrectly de-duping into a single tag today? |
In the |
I've asked a question on the issue to see if this is still something pressing enough to address (at least the original case folks were running into with Traeffik may no longer be an issue according to their docs at least). We can decide if we want to merge this anyway - if it's not actively impacting anyone any more we could leave that, but I do think it's better to not impose that restriction on case here in general. Personally I feel like it would be sufficient to just make this change and note it in the upgrade docs. My feeling (which is 100% pure wild speculation) is that it's probably unlikely enough to cause a major issue for users relying on their supplying upper case tags and having them converted to lower 🤷 . It certainly feels disproportionate to go through a lot more bother of making it backwards compatible not to mention the long-term added complexity of supporting optional modes. My two cents anyway! |
Seems from the issue this is still a blocker for Correct Traefik routing at least. I think we just need to note the behaviour change in upgrade docs and merge. Anyone disagree? |
and dedup a list of strings also forced them to be lowercase. Now there's another helper func that doesn't smash the case so use that instead.
CI Results: |
f0b71da
to
777dc08
Compare
Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
When support for service tags was added, the only way we had to parse
and dedup a list of strings also forced them to be lowercase. Now there's
another helper func that doesn't smash the case so use that instead.
Fixes #6427.